]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bpf: Disable bpf_refcount_acquire kfunc calls until race conditions are fixed
authorDave Marchevsky <davemarchevsky@fb.com>
Mon, 24 Apr 2023 20:43:21 +0000 (13:43 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 24 Apr 2023 21:02:11 +0000 (14:02 -0700)
commit7deca5eae83389ca40ac1b1bde96e4af17cca84f
tree3177280c48b4814b2acc4f88eeccb40770e3c296
parent35150203e30b52d657165e325e3abc3b29c2086d
bpf: Disable bpf_refcount_acquire kfunc calls until race conditions are fixed

As reported by Kumar in [0], the shared ownership implementation for BPF
programs has some race conditions which need to be addressed before it
can safely be used. This patch does so in a minimal way instead of
ripping out shared ownership entirely, as proper fixes for the issues
raised will follow ASAP, at which point this patch's commit can be
reverted to re-enable shared ownership.

The patch removes the ability to call bpf_refcount_acquire_impl from BPF
programs. Programs can only bump refcount and obtain a new owning
reference using this kfunc, so removing the ability to call it
effectively disables shared ownership.

Instead of changing success / failure expectations for
bpf_refcount-related selftests, this patch just disables them from
running for now.

  [0]: https://lore.kernel.org/bpf/d7hyspcow5wtjcmw4fugdgyp3fwhljwuscp3xyut5qnwivyeru@ysdq543otzv2/

Reported-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
Link: https://lore.kernel.org/r/20230424204321.2680232-1-davemarchevsky@fb.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c
tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c