]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
cifs: don't dereference smb_file_target before null check
authorColin Ian King <colin.king@canonical.com>
Thu, 1 Nov 2018 13:14:30 +0000 (13:14 +0000)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 02:00:04 +0000 (20:00 -0600)
commit7e828f6166d1285d9acb485c2c9d37e9698a0476
tree7940093e344d03e323b4d279c1cc59c42e68a8db
parent1ebc9861b45b18069b66c98e1a974c5e1422b6fe
cifs: don't dereference smb_file_target before null check

BugLink: https://bugs.launchpad.net/bugs/1836968
[ Upstream commit 8c6c9bed8773375b1d54ccca2911ec892c59db5d ]

There is a null check on dst_file->private data which suggests
it can be potentially null. However, before this check, pointer
smb_file_target is derived from dst_file->private and dereferenced
in the call to tlink_tcon, hence there is a potential null pointer
deference.

Fix this by assigning smb_file_target and target_tcon after the
null pointer sanity checks.

Detected by CoverityScan, CID#1475302 ("Dereference before null check")

Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/cifs/cifsfs.c