]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues
authorBrian Masney <masneyb@onstation.org>
Sun, 11 Nov 2018 01:34:11 +0000 (20:34 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 16 Nov 2018 22:15:03 +0000 (23:15 +0100)
commit7ed07855773814337b9814f1c3e866df52ebce68
tree4f3151d6224fa81bc8930c810282e51d3660d3b6
parenta62c36775ba873611b00b82ce7ebcd4ff2126111
pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues

When attempting to setup up a gpio hog, device probing will repeatedly
fail with -EPROBE_DEFERED errors. It is caused by a circular dependency
between the gpio and pinctrl frameworks. If the gpio-ranges property is
present in device tree, then the gpio framework will handle the gpio pin
registration and eliminate the circular dependency.

See Christian Lamparter's commit a86caa9ba5d7 ("pinctrl: msm: fix
gpio-hog related boot issues") for a detailed commit message that
explains the issue in much more detail. The code comment in this commit
came from Christian's commit.

I did not test this change against any hardware supported by this
particular driver, however I was able to validate this same fix works
for pinctrl-spmi-gpio.c using a LG Nexus 5 (hammerhead) phone.

Signed-off-by: Brian Masney <masneyb@onstation.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c