]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
reset: imx7: Fix always writing bits as 0
authorLeonard Crestez <leonard.crestez@nxp.com>
Fri, 20 Jul 2018 12:47:43 +0000 (15:47 +0300)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:48:45 +0000 (19:48 -0600)
commit7f0cef5c74a1349e4b4adf86395e2d036401b68d
treeea8344d1d2c5bf8be264164a62e671b713e7956c
parentd87828c8a4775902c0363dc88fb0d7f24b99642d
reset: imx7: Fix always writing bits as 0

BugLink: https://bugs.launchpad.net/bugs/1836117
[ Upstream commit 26fce0557fa639fb7bbc33e31a57cff7df25c3a0 ]

Right now the only user of reset-imx7 is pci-imx6 and the
reset_control_assert and deassert calls on pciephy_reset don't toggle
the PCIEPHY_BTN and PCIEPHY_G_RST bits as expected. Fix this by writing
1 or 0 respectively.

The reference manual is not very clear regarding SRC_PCIEPHY_RCR but for
other registers like MIPIPHY and HSICPHY the bits are explicitly
documented as "1 means assert, 0 means deassert".

The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/reset/reset-imx7.c