]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
tty: fix __tty_insert_flip_char regression
authorArnd Bergmann <arnd@arndb.de>
Wed, 2 Aug 2017 11:11:39 +0000 (13:11 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 28 Sep 2017 14:30:58 +0000 (10:30 -0400)
commit7f94c64f62f18e32c066be0c13859b6bf3469836
tree773ae9655b929c08816d3697bfb5f24d9b44601a
parent97a97d6610cadd37397e31f3d531da97d8437739
tty: fix __tty_insert_flip_char regression

BugLink: http://bugs.launchpad.net/bugs/1720154
commit 8a5a90a2a477b86a3dc2eaa5a706db9bfdd647ca upstream.

Sergey noticed a small but fatal mistake in __tty_insert_flip_char,
leading to an oops in an interrupt handler when using any serial
port.

The problem is that I accidentally took the tty_buffer pointer
before calling __tty_buffer_request_room(), which replaces the
buffer. This moves the pointer lookup to the right place after
allocating the new buffer space.

Fixes: 979990c62848 ("tty: improve tty_insert_flip_char() fast path")
Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/tty/tty_buffer.c