]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfsd: don't allow setting maxblksize after svc created
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 6 Aug 2010 22:00:33 +0000 (18:00 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 6 Aug 2010 22:00:33 +0000 (18:00 -0400)
commit7fa53cc872332b265bc5ba1266f39586f218ad4a
tree0583a66f8665581a7a9b613f30000e9093c9ff84
parente844a7b9805a2b74cfd34c8604f5bba3e0869305
nfsd: don't allow setting maxblksize after svc created

It's harmless to set this after the server is created, but also
ineffective, since the value is only used at the time of
svc_create_pooled().  So fail the attempt, in keeping with the pattern
set by write_versions, write_{lease,grace}time and write_recoverydir.

(This could break userspace that tried to write to nfsd/max_block_size
between setting up sockets and starting the server.  However, such code
wouldn't have worked anyway, and I don't know of any examples--rpc.nfsd
in nfs-utils, probably the only user of the interface, doesn't do that.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfsctl.c