]> git.proxmox.com Git - mirror_qemu.git/commit
hw/smbios: Fix leaked fd in save_opt_one() error path
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 30 Oct 2020 15:27:42 +0000 (16:27 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 3 Nov 2020 12:19:27 +0000 (07:19 -0500)
commit8055d2fb7f4717c6aa7c4ca801a487153945a15d
treeb843c2cae2468c78e3296b1d801917a3c4583e73
parent8faf2f1de40e2fb919d8f584478d407a2fa7c80a
hw/smbios: Fix leaked fd in save_opt_one() error path

Fix the following Coverity issue (RESOURCE_LEAK):

  CID 1432879: Resource leak

    Handle variable fd going out of scope leaks the handle.

Replace a close() call by qemu_close() since the handle is
opened with qemu_open().

Fixes: bb99f4772f5 ("hw/smbios: support loading OEM strings values from a file")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201030152742.1553968-1-philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/smbios/smbios.c