]> git.proxmox.com Git - mirror_qemu.git/commit
hw/ufs: avoid generating the same ID string for different LU devices
authorAkinobu Mita <akinobu.mita@gmail.com>
Mon, 4 Dec 2023 15:05:43 +0000 (00:05 +0900)
committerJeuk Kim <jeuk20.kim@samsung.com>
Tue, 5 Dec 2023 04:57:18 +0000 (13:57 +0900)
commit80a37b039ea9473d038bcef8bb64f4213affeae8
tree48f87dc70ef5988a54e35e19631088558eb1f6d5
parent1664d74c50739401c8b40e8b514d12b5fc250067
hw/ufs: avoid generating the same ID string for different LU devices

QEMU would not start when trying to create two UFS host controllers and
a UFS logical unit for each with the following options:

-device ufs,id=bus0 \
-device ufs-lu,drive=drive1,bus=bus0,lun=0 \
-device ufs,id=bus1 \
-device ufs-lu,drive=drive2,bus=bus1,lun=0 \

This is because the same ID string ("0:0:0/scsi-disk") is generated
for both UFS logical units.

To fix this issue, prepend the parent pci device's path to make
the ID string unique.
("0000:00:03.0/0:0:0/scsi-disk" and "0000:00:04.0/0:0:0/scsi-disk")

Resolves: #2018
Fixes: 096434fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem")
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231204150543.48252-1-akinobu.mita@gmail.com>
Signed-off-by: Jeuk Kim <jeuk20.kim@samsung.com>
hw/ufs/ufs.c