]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
x86: fix oprofile + hibernation badness
authorAndi Kleen <ak@linux.intel.com>
Tue, 19 Aug 2008 01:13:38 +0000 (03:13 +0200)
committerIngo Molnar <mingo@elte.hu>
Wed, 20 Aug 2008 14:18:31 +0000 (16:18 +0200)
commit80a8c9fffa78f57d7d4351af2f15a56386805ceb
tree22b1e5fdeda17271b94ffac2c6abc7ff8728082d
parent99dd8713306a89f3e106143581244e550e00a644
x86: fix oprofile + hibernation badness

Vegard Nossum reported oprofile + hibernation problems:

> Now some warnings:
>
> ------------[ cut here ]------------
> WARNING: at /uio/arkimedes/s29/vegardno/git-working/linux-2.6/kernel/smp.c:328 s
> mp_call_function_mask+0x194/0x1a0()

The usual problem: the suspend function when interrupts are
already disabled calls smp_call_function which is not allowed with
interrupt off. But at this point all the other CPUs should be already
down anyways, so it should be enough to just drop that.

This patch should fix that problem at least by fixing cpu hotplug&
suspend support.

[ mingo@elte.hu: fixed 5 coding style errors. ]

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Tested-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/oprofile/nmi_int.c