]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915/icl: Disable master intr before reading
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Mon, 15 Oct 2018 14:14:40 +0000 (17:14 +0300)
committerMika Kuoppala <mika.kuoppala@linux.intel.com>
Tue, 16 Oct 2018 10:11:23 +0000 (13:11 +0300)
commit81067b71c1d944ea1f93ee67ef0be16d8b4957b4
tree71375f2e1bb2640c6b47b21da914b9c44e9477b8
parent95b0e7c14c500ac7522924a54e6beddf69d383ec
drm/i915/icl: Disable master intr before reading

Disable master interrupt before reading level indications.
This will close a race where we get a level indication between
reading and disabling, generating an extra interrupt where we
could have avoided one.

Further, as the reading acts also as a post, replace the
write/post on the irq reset with the helper. On enabling side,
posting doesn't serve any purpose so it can also be replaced
with helper.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181015141440.21845-3-mika.kuoppala@linux.intel.com
drivers/gpu/drm/i915/i915_irq.c