]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:23 +0000 (22:25 +0100)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:18 +0000 (17:46 -0600)
commit811d39411605213cb105e810b91bc06c27adf9e5
tree7c2b5fdf6263fca20705feb646bfadd069243a45
parenta9f30ae21e41e5ab3ab9610f79d646fe15c68ff8
ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family

BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit fbe9c9bb2e929865500a0985735f81c0142accad ]

The Maxim PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: f48b5050c301 ("ARM: dts: exynos: add Samsung's Exynos4412-based P4 Note boards")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-7-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/arm/boot/dts/exynos4412-p4note.dtsi