]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Bluetooth: hci_core: Fix unbalanced unlock in set_device_flags()
authorHans de Goede <hdegoede@redhat.com>
Wed, 2 Mar 2022 13:44:39 +0000 (14:44 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 3 Mar 2022 10:35:10 +0000 (11:35 +0100)
commit815d5121927093017947fd76e627da03f0f70be7
treef8618ffe58fe491cbfc11f00c59921c98802dbf4
parentf8e9bd34cedd89b93b1167aa32ab8ecd6c2ccf4a
Bluetooth: hci_core: Fix unbalanced unlock in set_device_flags()

There is only one "goto done;" in set_device_flags() and this happens
*before* hci_dev_lock() is called, move the done label to after the
hci_dev_unlock() to fix the following unlock balance:

[   31.493567] =====================================
[   31.493571] WARNING: bad unlock balance detected!
[   31.493576] 5.17.0-rc2+ #13 Tainted: G         C  E
[   31.493581] -------------------------------------
[   31.493584] bluetoothd/685 is trying to release lock (&hdev->lock) at:
[   31.493594] [<ffffffffc07603f5>] set_device_flags+0x65/0x1f0 [bluetooth]
[   31.493684] but there are no more locks to release!

Note this bug has been around for a couple of years, but before
commit fe92ee6425a2 ("Bluetooth: hci_core: Rework hci_conn_params flags")
supported_flags was hardcoded to "((1U << HCI_CONN_FLAG_MAX) - 1)" so
the check for unsupported flags which does the "goto done;" never
triggered.

Fixes: fe92ee6425a2 ("Bluetooth: hci_core: Rework hci_conn_params flags")
Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/mgmt.c