]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
vhost: correctly check the return value of translate_desc() in log_used()
authorJason Wang <jasowang@redhat.com>
Tue, 19 Feb 2019 06:53:44 +0000 (14:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Feb 2019 21:14:45 +0000 (13:14 -0800)
commit816db7663565cd23f74ed3d5c9240522e3fb0dda
treec44fa4c748a27f6898a07c14a5e6afa936e7f223
parent5cd856a5ef9aa189df757c322be34ad735a5b17f
vhost: correctly check the return value of translate_desc() in log_used()

When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.

Detected by CoverityScan, CID# 1442593:  Control flow issues  (DEADCODE)

Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/vhost/vhost.c