]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
gpio: aspeed: fix ast2600 bank properties
authorTao Ren <rentao.bupt@gmail.com>
Wed, 16 Sep 2020 20:42:16 +0000 (13:42 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:48:11 +0000 (14:48 +0100)
commit81919074582d0ce46f4b8ede4ee3c20da791b529
treebd098c1a7e2f71ff83972bc4babd4b738ade9a93
parentb88532e8612e8900f317b2bbeb9e2fc5287593e5
gpio: aspeed: fix ast2600 bank properties

BugLink: https://bugs.launchpad.net/bugs/1900632
[ Upstream commit 3e640b1eec38e4c8eba160f26cba4f592e657f3d ]

GPIO_U is mapped to the least significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_U is input only. All
the other bits need to be 1 because GPIO_V/W/X support both input and
output modes.

Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
according bits need to be 1 because GPIO_Y/Z support both input and
output modes.

Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
drivers/gpio/gpio-aspeed.c