]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iio: adc: cpcap: fix incorrect validation
authorPan Bian <bianpan2016@163.com>
Sun, 12 Nov 2017 16:01:20 +0000 (00:01 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 2 Dec 2017 11:15:13 +0000 (11:15 +0000)
commit81b039ec36a41a5451e1e36f05bb055eceab1dc8
tree37244f40cbd7b4ed0874b772118586e5fdcb7027
parent0590cdfead8cd6319cc58b5dbe8ab9fbaabae131
iio: adc: cpcap: fix incorrect validation

Function platform_get_irq_byname() returns a negative error code on
failure, and a zero or positive number on success. However, in function
cpcap_adc_probe(), positive IRQ numbers are also taken as error cases.
Use "if (ddata->irq < 0)" instead of "if (!ddata->irq)" to validate the
return value of platform_get_irq_byname().

Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: 25ec249632d50 ("iio: adc: cpcap: Add minimal support for CPCAP PMIC ADC")
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/cpcap-adc.c