]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
tracing: Fix trace_pipe behavior for instance traces
authorTahsin Erdogan <tahsin@google.com>
Sun, 17 Sep 2017 10:23:48 +0000 (03:23 -0700)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 12 Oct 2017 21:20:09 +0000 (16:20 -0500)
commit81cade5c2d2219136e01b46ceb3e54af30e95767
tree9f3aca5d77d081517f158fe587c81b42f4a8d8b7
parent94df652803f4221056253b5244426d172a82bf84
tracing: Fix trace_pipe behavior for instance traces

BugLink: http://bugs.launchpad.net/bugs/1721777
commit 75df6e688ccd517e339a7c422ef7ad73045b18a2 upstream.

When reading data from trace_pipe, tracing_wait_pipe() performs a
check to see if tracing has been turned off after some data was read.
Currently, this check always looks at global trace state, but it
should be checking the trace instance where trace_pipe is located at.

Because of this bug, cat instances/i1/trace_pipe in the following
script will immediately exit instead of waiting for data:

cd /sys/kernel/debug/tracing
echo 0 > tracing_on
mkdir -p instances/i1
echo 1 > instances/i1/tracing_on
echo 1 > instances/i1/events/sched/sched_process_exec/enable
cat instances/i1/trace_pipe

Link: http://lkml.kernel.org/r/20170917102348.1615-1-tahsin@google.com
Fixes: 10246fa35d4f ("tracing: give easy way to clear trace buffer")
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
kernel/trace/trace.c