]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
powerpc/xmon: Fix data-breakpoint
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Tue, 22 Nov 2016 09:25:59 +0000 (14:55 +0530)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 13 Mar 2017 21:20:54 +0000 (15:20 -0600)
commit81ebb374fed10efcdf42128fc5472aa868cb4d13
treef62275f48cd44847188f1e0a5d683aa87ca4a4f8
parentb0ff1d4e139401e896341ece8e27680349332e71
powerpc/xmon: Fix data-breakpoint

BugLink: http://bugs.launchpad.net/bugs/1672544
commit c21a493a2b44650707d06741601894329486f2ad upstream.

Currently xmon data-breakpoint feature is broken.

Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
be called by do_break via notifier chains mechanism. If watchpoint is
registered by xmon, hw_breakpoint_handler won't find any associated
perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break
also returns without notifying to xmon.

Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
find any perf_event associated with matched watchpoint, rather than
NOTIFY_STOP, which tells the core code to continue calling the other
breakpoint handlers including the xmon one.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
arch/powerpc/kernel/hw_breakpoint.c