]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
efi/esrt: Cleanup bad memory map log messages
authorDaniel Drake <drake@endlessm.com>
Tue, 7 Feb 2017 19:08:23 +0000 (13:08 -0600)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Fri, 17 Mar 2017 18:53:12 +0000 (18:53 +0000)
commit822f5845f710e57d7e2df1fd1ee00d6e19d334fe
tree5fe3e4692fb8375faf8e1aeea1c2eae38c342250
parent4495c08e84729385774601b5146d51d9e5849f81
efi/esrt: Cleanup bad memory map log messages

The Intel Compute Stick STCK1A8LFC and Weibu F3C platforms both
log 2 error messages during boot:

   efi: requested map not found.
   esrt: ESRT header is not in the memory map.

Searching the web, this seems to affect many other platforms too.
Since these messages are logged as errors, they appear on-screen during
the boot process even when using the "quiet" boot parameter used by
distros.

Demote the ESRT error to a warning so that it does not appear on-screen,
and delete the error logging from efi_mem_desc_lookup; both callsites
of that function log more specific messages upon failure.

Out of curiosity I looked closer at the Weibu F3C. There is no entry in
the UEFI-provided memory map which corresponds to the ESRT pointer, but
hacking the code to map it anyway, the ESRT does appear to be valid with
2 entries.

Signed-off-by: Daniel Drake <drake@endlessm.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Acked-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
drivers/firmware/efi/efi.c
drivers/firmware/efi/esrt.c