]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
net: systemport: suppress warnings on failed Rx SKB allocations
authorDoug Berger <opendmb@gmail.com>
Thu, 23 Apr 2020 23:13:30 +0000 (16:13 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 25 May 2020 08:42:32 +0000 (10:42 +0200)
commit824beb90e1b2505ef8848d60cdf61dae848cc159
tree16eb1346b22c1d3b09fa8ec203f5f125604673e3
parent351e3d88f42673881a4ce9bad060926922ddf022
net: systemport: suppress warnings on failed Rx SKB allocations

BugLink: https://bugs.launchpad.net/bugs/1878040
[ Upstream commit 3554e54a46125030c534820c297ed7f6c3907e24 ]

The driver is designed to drop Rx packets and reclaim the buffers
when an allocation fails, and the network interface needs to safely
handle this packet loss. Therefore, an allocation failure of Rx
SKBs is relatively benign.

However, the output of the warning message occurs with a high
scheduling priority that can cause excessive jitter/latency for
other high priority processing.

This commit suppresses the warning messages to prevent scheduling
problems while retaining the failure count in the statistics of
the network interface.

Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/broadcom/bcmsysport.c