]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
serial: 8250_dw: Revert "Move definitions to the shared header"
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 14 May 2024 19:05:54 +0000 (22:05 +0300)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Fri, 2 Aug 2024 14:27:22 +0000 (16:27 +0200)
commit825b4448f9cec4b95636097bbbb4b3d56228fc60
tree0bb9327c751ee10e10d08922c780ac08999510f9
parentf5bd2868087fcfe82c25d22d5db5a002c226d830
serial: 8250_dw: Revert "Move definitions to the shared header"

BugLink: https://bugs.launchpad.net/bugs/2075154
commit 2c94512055f362dd789e0f87b8566feeddec83c9 upstream.

This reverts commit d9666dfb314e1ffd6eb9c3c4243fe3e094c047a7.

The container of the struct dw8250_port_data is private to the actual
driver. In particular, 8250_lpss and 8250_dw use different data types
that are assigned to the UART port private_data. Hence, it must not
be used outside the specific driver.

Fix the mistake made in the past by moving the respective definitions
to the specific driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240514190730.2787071-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/tty/serial/8250/8250_dw.c
drivers/tty/serial/8250/8250_dwlib.h