]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 10 Apr 2018 13:17:29 +0000 (21:17 +0800)
committerJon Mason <jdmason@kudzu.us>
Mon, 11 Jun 2018 19:20:59 +0000 (15:20 -0400)
commit82edcc758f273ed3afd308746dd69376d5b1024d
tree3aa9dfecafb053dfc07a1f2f8673c00fdd30c941
parent081a698639d793d92c28e785d9b5b085698f8008
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw

ntb_transport_setup_qp_mw() is never called in atomic context.

ntb_transport_setup_qp_mw() is only called by ntb_transport_link_work(),
which is set as a parameter of INIT_DELAYED_WORK()
in ntb_transport_probe().

Despite never getting called from atomic context,
ntb_transport_setup_qp_mw() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/ntb_transport.c