]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: delete stale packet_mclist entries
authorFrancesco Ruggeri <fruggeri@arista.com>
Mon, 9 Mar 2015 18:51:04 +0000 (11:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Mar 2015 20:17:43 +0000 (16:17 -0400)
commit82f17091e68254d1612b42cf23291cad63cfaf04
treedcffa6fb6b17a6adc0debb924dfcdd855feb0977
parent0b2eb3e9bc738c23784b9281dd035ee0b450d98a
net: delete stale packet_mclist entries

When an interface is deleted from a net namespace the ifindex in the
corresponding entries in PF_PACKET sockets' mclists becomes stale.
This can create inconsistencies if later an interface with the same ifindex
is moved from a different namespace (not that unlikely since ifindexes are
per-namespace).
In particular we saw problems with dev->promiscuity, resulting
in "promiscuity touches roof, set promiscuity failed. promiscuity
feature of device might be broken" warnings and EOVERFLOW failures of
setsockopt(PACKET_ADD_MEMBERSHIP).
This patch deletes the mclist entries for interfaces that are deleted.
Since this now causes setsockopt(PACKET_DROP_MEMBERSHIP) to fail with
EADDRNOTAVAIL if called after the interface is deleted, also make
packet_mc_drop not fail.

Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c