]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
writeback: account the number of pages written back
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 28 Jun 2023 18:55:48 +0000 (19:55 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 8 Jul 2023 16:29:30 +0000 (09:29 -0700)
commit8344a3d44be3d18671e18c4ba23bb03dd21e14ad
treed7e0f804bcf56763da3324a659ccfde50bccc4b1
parent6dca4ac6fc91fd41ea4d6c4511838d37f4e0eab2
writeback: account the number of pages written back

nr_to_write is a count of pages, so we need to decrease it by the number
of pages in the folio we just wrote, not by 1.  Most callers specify
either LONG_MAX or 1, so are unaffected, but writeback_sb_inodes() might
end up writing 512x as many pages as it asked for.

Dave added:

: XFS is the only filesystem this would affect, right?  AFAIA, nothing
: else enables large folios and uses writeback through
: write_cache_pages() at this point...
:
: In which case, I'd be surprised if much difference, if any, gets
: noticed by anyone.

Link: https://lkml.kernel.org/r/20230628185548.981888-1-willy@infradead.org
Fixes: 793917d997df ("mm/readahead: Add large folio readahead")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page-writeback.c