]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
xen/gntdev.c: Mark pages as dirty
authorSouptick Joarder <jrdr.linux@gmail.com>
Sun, 6 Sep 2020 06:51:53 +0000 (12:21 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:02:35 +0000 (12:02 +0100)
commit8389822e8eca845f4dd42e48f607817f17451673
treeea2c6e577f4c81d416283aca12790ec7c5c6d1a2
parent55aa689f4e81312f9a89a9fbbc82c39b04552d5e
xen/gntdev.c: Mark pages as dirty

BugLink: https://bugs.launchpad.net/bugs/1904445
commit 779055842da5b2e508f3ccf9a8153cb1f704f566 upstream.

There seems to be a bug in the original code when gntdev_get_page()
is called with writeable=true then the page needs to be marked dirty
before being put.

To address this, a bool writeable is added in gnt_dev_copy_batch, set
it in gntdev_grant_copy_seg() (and drop `writeable` argument to
gntdev_get_page()) and then, based on batch->writeable, use
set_page_dirty_lock().

Fixes: a4cdb556cae0 (xen/gntdev: add ioctl for grant copy)
Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1599375114-32360-1-git-send-email-jrdr.linux@gmail.com
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/xen/gntdev.c