]> git.proxmox.com Git - mirror_qemu.git/commit
block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct
authorThomas Huth <thuth@redhat.com>
Mon, 25 Feb 2019 11:59:30 +0000 (12:59 +0100)
committerKevin Wolf <kwolf@redhat.com>
Mon, 25 Feb 2019 14:09:48 +0000 (15:09 +0100)
commit83c68e149a9365a3db6de751f219ad1d79928462
treeec61e211e094ec3100de65479936b23a6f955678
parentc1c43990846b89d740487d7022dce9415453f344
block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct

The QEMU_PACKED is causing a compiler warning/error with GCC 9:

  CC      block/nvme.o
block/nvme.c: In function ‘nvme_create_queue_pair’:
block/nvme.c:209:22: error: taking address of packed member of
 ‘struct <anonymous>’ may result in an unaligned pointer value
 [-Werror=address-of-packed-member]
  209 |     q->sq.doorbell = &s->regs->doorbells[idx * 2 * s->doorbell_scale];

All members of the struct are naturally aligned, so there should
not be the need for QEMU_PACKED here, and the following QEMU_BUILD_BUG_ON
also ensures that there is no padding. Thus simply remove the QEMU_PACKED
here.

Buglink: https://bugs.launchpad.net/qemu/+bug/1817525
Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/nvme.c