]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
authorPan Bian <bianpan2016@163.com>
Sun, 23 Apr 2017 10:23:21 +0000 (18:23 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 19 Jul 2017 07:59:14 +0000 (09:59 +0200)
commit83cc900f4d2ba3fd7edc5ad0cab658276279a834
tree837b045dc90a4f09dbe103d8db21782c57a014d7
parent0179f65fdccc790f2659e69002a376379a987630
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()

BugLink: http://bugs.launchpad.net/bugs/1702863
commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream.

In function amd_iommu_bind_pasid(), the control flow jumps
to label out_free when pasid_state->mm and mm is NULL. And
mmput(mm) is called.  In function mmput(mm), mm is
referenced without validation. This will result in a NULL
dereference bug. This patch fixes the bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/iommu/amd_iommu_v2.c