]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
wireless: remove superfluous if statement in regulatory code
authorJohn Linville <linville@tuxdriver.com>
Wed, 24 Jun 2015 15:42:25 +0000 (11:42 -0400)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 17 Jul 2015 13:38:27 +0000 (15:38 +0200)
commit841b351cf98e0b4ef25f6459d35251e63c0a7a49
treeb6f60880d931f5c1fbca07dfe67f626df1b4567f
parent33d8783c58427683b533664f67f8c4378ed64495
wireless: remove superfluous if statement in regulatory code

Commit eeca9fce1d71 ('cfg80211: Schedule timeout for all CRDA calls')
left behind a superfluous check after it removed some earlier code.

In reg_process_hint, the test of "treatment == REG_REQ_IGNORE ||
treatment == REG_REQ_ALREADY_SET" is superfluous because the code in the
if-then branch is identical to the code after the if statement.

Coverity CID #1295939

I also removed the unnecessary assignment of treatment in this case,
and added a comment reminding any future patch authors to ensure that
treatment is properly assigned before it is used after the switch.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/reg.c