]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tracing/kprobes, x86/ptrace: Fix regs argument order for i386
authorVamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Fri, 28 Aug 2020 11:32:46 +0000 (17:02 +0530)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Thu, 17 Sep 2020 06:47:06 +0000 (00:47 -0600)
commit842393a4c1c9b96cb8aca45cb2dea0ffc0e99fab
treef4ee16e4b74bd050d1a6df8772b23e2449434337
parent0baf536689e8958d323950e6683c9c319171f6de
tracing/kprobes, x86/ptrace: Fix regs argument order for i386

BugLink: https://bugs.launchpad.net/bugs/1895880
commit 2356bb4b8221d7dc8c7beb810418122ed90254c9 upstream.

On i386, the order of parameters passed on regs is eax,edx,and ecx
(as per regparm(3) calling conventions).

Change the mapping in regs_get_kernel_argument(), so that arg1=ax
arg2=dx, and arg3=cx.

Running the selftests testcase kprobes_args_use.tc shows the result
as passed.

Fixes: 3c88ee194c28 ("x86: ptrace: Add function argument access API")
Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/20200828113242.GA1424@cosmos
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/x86/include/asm/ptrace.h