]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
KVM: SVM: Make sure GHCB is mapped before updating
authorTom Lendacky <thomas.lendacky@amd.com>
Fri, 9 Apr 2021 14:38:42 +0000 (09:38 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 18 Jun 2021 09:06:55 +0000 (11:06 +0200)
commit84337dd58cb010541590db27e9751dd31beb2dcd
tree5c182cce762e598c5b09d1146ff2bae80dfbfc3f
parent1c85d57e9ba5d34772b8bd604a4d867d3b33c470
KVM: SVM: Make sure GHCB is mapped before updating

BugLink: https://bugs.launchpad.net/bugs/1931292
commit a3ba26ecfb569f4aa3f867e80c02aa65f20aadad upstream.

Access to the GHCB is mainly in the VMGEXIT path and it is known that the
GHCB will be mapped. But there are two paths where it is possible the GHCB
might not be mapped.

The sev_vcpu_deliver_sipi_vector() routine will update the GHCB to inform
the caller of the AP Reset Hold NAE event that a SIPI has been delivered.
However, if a SIPI is performed without a corresponding AP Reset Hold,
then the GHCB might not be mapped (depending on the previous VMEXIT),
which will result in a NULL pointer dereference.

The svm_complete_emulated_msr() routine will update the GHCB to inform
the caller of a RDMSR/WRMSR operation about any errors. While it is likely
that the GHCB will be mapped in this situation, add a safe guard
in this path to be certain a NULL pointer dereference is not encountered.

Fixes: f1c6366e3043 ("KVM: SVM: Add required changes to support intercepts under SEV-ES")
Fixes: 647daca25d24 ("KVM: SVM: Add support for booting APs in an SEV-ES guest")
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: stable@vger.kernel.org
Message-Id: <a5d3ebb600a91170fc88599d5a575452b3e31036.1617979121.git.thomas.lendacky@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/x86/kvm/svm/sev.c
arch/x86/kvm/svm/svm.c