]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
vfs: check submounts and drop atomically
authorMiklos Szeredi <mszeredi@suse.cz>
Thu, 5 Sep 2013 09:44:36 +0000 (11:44 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 5 Sep 2013 20:23:41 +0000 (16:23 -0400)
commit848ac114e847af3f1f9141c90a39ebe79bdb13b3
tree3673b97171b0e0bc5b179908b4ad15ede9a91b35
parentdb14fc3abcd5dcc9b32ad5b9dd5b8f9e16295a39
vfs: check submounts and drop atomically

We check submounts before doing d_drop() on a non-empty directory dentry in
NFS (have_submounts()), but we do not exclude a racing mount.

 Process A: have_submounts() -> returns false
 Process B: mount() -> success
 Process A: d_drop()

This patch prepares the ground for the fix by doing the following
operations all under the same rename lock:

  have_submounts()
  shrink_dcache_parent()
  d_drop()

This is actually an optimization since have_submounts() and
shrink_dcache_parent() both traverse the same dentry tree separately.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: David Howells <dhowells@redhat.com>
CC: Steven Whitehouse <swhiteho@redhat.com>
CC: Trond Myklebust <Trond.Myklebust@netapp.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c
include/linux/dcache.h