]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
i2c: qcom-geni: Fix runtime PM mismatch with child devices
authorStephen Boyd <swboyd@chromium.org>
Fri, 2 Nov 2018 20:57:32 +0000 (13:57 -0700)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 9 Nov 2018 16:25:48 +0000 (17:25 +0100)
commit848bd3f3de9d44950c00eda6c115e8e9785440da
tree5399bc683adbaffd52636d5726e5ffaf53c95f1c
parent350784e79230f85e9007c4c7d8b2259717d67a4d
i2c: qcom-geni: Fix runtime PM mismatch with child devices

We need to enable runtime PM on this i2c controller before populating
child devices with i2c_add_adapter(). Otherwise, if a child device uses
runtime PM and stays runtime PM enabled we'll get the following warning
at boot.

 Enabling runtime PM for inactive device (a98000.i2c) with active children

[...]

 Call trace:
  pm_runtime_enable+0xd8/0xf8
  geni_i2c_probe+0x440/0x460
  platform_drv_probe+0x74/0xc8
[...]

Let's move the runtime PM enabling and setup to before we add the
adapter, so that this device can respond to runtime PM requests from
children.

Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-qcom-geni.c