]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mptcp: Do TCP fallback on early DSS checksum failure
authorMat Martineau <mathew.j.martineau@linux.intel.com>
Tue, 17 May 2022 18:02:12 +0000 (11:02 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 10 Aug 2022 07:22:47 +0000 (09:22 +0200)
commit84f264d8d0b2ed95a13c7ca4b9900a0947f865d0
treed8a79fec693f26622ca4956f8f905dab14d0c764
parentaf4773cc81e6fc827c6d0a54dcbe9aff1d6a4ab4
mptcp: Do TCP fallback on early DSS checksum failure

BugLink: https://bugs.launchpad.net/bugs/1981468
commit ae66fb2ba6c3dcaf8b9612b65aa949a1a4bed150 upstream.

RFC 8684 section 3.7 describes several opportunities for a MPTCP
connection to "fall back" to regular TCP early in the connection
process, before it has been confirmed that MPTCP options can be
successfully propagated on all SYN, SYN/ACK, and data packets. If a peer
acknowledges the first received data packet with a regular TCP header
(no MPTCP options), fallback is allowed.

If the recipient of that first data packet finds a MPTCP DSS checksum
error, this provides an opportunity to fail gracefully with a TCP
fallback rather than resetting the connection (as might happen if a
checksum failure were detected later).

This commit modifies the checksum failure code to attempt fallback on
the initial subflow of a MPTCP connection, only if it's a failure in the
first data mapping. In cases where the peer initiates the connection,
requests checksums, is the first to send data, and the peer is sending
incorrect checksums (see
https://github.com/multipath-tcp/mptcp_net-next/issues/275), this allows
the connection to proceed as TCP rather than reset.

Fixes: dd8bcd1768ff ("mptcp: validate the data checksum")
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[mathew.j.martineau: backport: Resolved bitfield conflict in protocol.h]
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/mptcp/protocol.h
net/mptcp/subflow.c