]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
watchdog: constify watchdog_ops structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 1 Sep 2016 17:35:26 +0000 (19:35 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Sat, 24 Sep 2016 06:50:10 +0000 (08:50 +0200)
commit85f15cfc213da88d9eb01c943be454328b104f3c
treed1505e371dd0ca9654fea58181279378e5bce5e1
parent7123f253f02b7370ad25d9047fd91a5ef6ae551f
watchdog: constify watchdog_ops structures

Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure.  This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };

@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct watchdog_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/bcm7038_wdt.c
drivers/watchdog/cadence_wdt.c
drivers/watchdog/kempld_wdt.c
drivers/watchdog/rn5t618_wdt.c
drivers/watchdog/softdog.c
drivers/watchdog/w83627hf_wdt.c