]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
nvmet: don't check iosqes,iocqes for discovery controllers
authorSagi Grimberg <sagi@grimberg.me>
Mon, 15 Mar 2021 22:34:51 +0000 (15:34 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 23 Apr 2021 09:51:00 +0000 (11:51 +0200)
commit862ec0ecf47276d7848b52efc41eec69727e9a85
treebbf5e2ad38309e6bb14acb6029aebdd01e90d9fd
parentad3890cbae3bd5e2db3b5952c5fd5bccfcd277c1
nvmet: don't check iosqes,iocqes for discovery controllers

BugLink: https://bugs.launchpad.net/bugs/1923214
commit d218a8a3003e84ab136e69a4e30dd4ec7dab2d22 upstream.

From the base spec, Figure 78:

  "Controller Configuration, these fields are defined as parameters to
   configure an "I/O Controller (IOC)" and not to configure a "Discovery
   Controller (DC).

   ...
   If the controller does not support I/O queues, then this field shall
   be read-only with a value of 0h

Just perform this check for I/O controllers.

Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
Reported-by: Belanger, Martin <Martin.Belanger@dell.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/nvme/target/core.c