]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
firmware: arm_scpi: Fix string overflow in SCPI genpd driver
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 9 Dec 2021 12:04:56 +0000 (12:04 +0000)
committerArnd Bergmann <arnd@arndb.de>
Mon, 13 Dec 2021 14:17:37 +0000 (15:17 +0100)
commit865ed67ab955428b9aa771d8b4f1e4fb7fd08945
treec1c42564eaab0032d755d246a66b4ce7fed9542f
parent38d5b296d39e8c0afe8efd4e351e12960cc3881e
firmware: arm_scpi: Fix string overflow in SCPI genpd driver

Without the bound checks for scpi_pd->name, it could result in the buffer
overflow when copying the SCPI device name from the corresponding device
tree node as the name string is set at maximum size of 30.

Let us fix it by using devm_kasprintf so that the string buffer is
allocated dynamically.

Fixes: 8bec4337ad40 ("firmware: scpi: add device power domain support using genpd")
Reported-by: Pedro Batista <pedbap.g@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: stable@vger.kernel.org
Cc: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20211209120456.696879-1-sudeep.holla@arm.com'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/firmware/scpi_pm_domain.c