]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ssb: sdio: Don't overwrite const buffer if block_write fails
authorMichael Buesch <m@bues.ch>
Sat, 15 May 2021 19:02:52 +0000 (21:02 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:44:54 +0000 (09:44 +0200)
commit869c9fb943236383e69f1d1b325c3a8a4f4a3df7
tree755abb44e42456ae7ebd1db8064ced9bed98b9a5
parent8d9f13b944d420b125c776cb369af1f882d658e7
ssb: sdio: Don't overwrite const buffer if block_write fails

BugLink: https://bugs.launchpad.net/bugs/1938199
commit 47ec636f7a25aa2549e198c48ecb6b1c25d05456 upstream.

It doesn't make sense to clobber the const driver-side buffer, if a
write-to-device attempt failed. All other SSB variants (PCI, PCMCIA and SoC)
also don't corrupt the buffer on any failure in block_write.
Therefore, remove this memset from the SDIO variant.

Signed-off-by: Michael Büsch <m@bues.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210515210252.318be2ba@wiggum
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/ssb/sdio.c