]> git.proxmox.com Git - mirror_qemu.git/commit
dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes
authorEric Blake <eblake@redhat.com>
Mon, 25 Sep 2017 14:55:14 +0000 (09:55 -0500)
committerKevin Wolf <kwolf@redhat.com>
Fri, 6 Oct 2017 14:28:58 +0000 (16:28 +0200)
commit86f6ae67e157362f3b141649874213ce01dcc622
tree43fde77c0d2169679da89982ac545ef739d6fc5d
parent993e6525bfcc67ba48fe55bd64ec043a4b721e1d
dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes

Right now, the dirty-bitmap code exposes the fact that we use
a scale of sector granularity in the underlying hbitmap to anything
that wants to serialize a dirty bitmap.  It's nicer to uniformly
expose bytes as our dirty-bitmap interface, matching the previous
change to bitmap size.  The only caller to serialization is currently
qcow2-cluster.c, which becomes a bit more verbose because it is still
tracking sectors for other reasons, but a later patch will fix that
to more uniformly use byte offsets everywhere.  Likewise, within
dirty-bitmap, we have to add more assertions that we are not
truncating incorrectly, which can go away once the internal hbitmap
is byte-based rather than sector-based.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/dirty-bitmap.c
block/qcow2-bitmap.c
include/block/dirty-bitmap.h