]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/i915/cnl: Fix PLL mapping.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 3 Oct 2017 22:08:58 +0000 (15:08 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 16 Oct 2017 23:50:04 +0000 (16:50 -0700)
commit87145d95c3d8297fb74762bd92e022d7f5cc250c
treea7c02bc97fc4a36a92946470923456a06d4b37bb
parenta27d5a44ec87a019d818a82d0475b5d38856691e
drm/i915/cnl: Fix PLL mapping.

On PLL Enable sequence we need to "Configure DPCLKA_CFGCR0 to turn on
the clock for the DDI and map the DPLL to the DDI"

So we first do the map and then we unset DDI_CLK_OFF to turn the clock
on. We do this in 2 separated steps.

However, on this second step where we should only unset the off bit we are
also unmapping the ddi from the pll. So we end up using the pll 0
for almost everything. Consequently breaking cases with more than one
display.

Fixes: 555e38d27317 ("drm/i915/cnl: DDI - PLL mapping")
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Kahola, Mika <mika.kahola@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: James Ausmus <james.ausmus@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171003220859.21352-2-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/intel_ddi.c