]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
[media] bttv/cx25821/cx88/ivtv: use sg_next instead of sg++
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 21 Nov 2014 10:57:12 +0000 (07:57 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 25 Nov 2014 10:12:53 +0000 (08:12 -0200)
commit872dfcfe82438f5211f5fa1dc6406d033a8a2448
treed3a736a51219e493ed94c3ecc203b36168d887fc
parent6dfa5131804e8cc0866e2f21ed79ce4b08976cff
[media] bttv/cx25821/cx88/ivtv: use sg_next instead of sg++

Never use sg++, always use sg = sg_next(sg). Scatterlist entries can
be combined if the memory is contiguous but sg++ won't know about that.

As far as I can tell cx88 and ivtv are really broken because of this,
and bttv and cx25821 are OK because vb1 doesn't combine scatterlist
entries.

But regardless, sg++ should never be used, only sg_next is safe.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/bt8xx/bttv-risc.c
drivers/media/pci/cx25821/cx25821-core.c
drivers/media/pci/cx88/cx88-core.c
drivers/media/pci/ivtv/ivtv-udma.c