]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
arm64: dts: qcom: pm8916: Remove invalid reg size from wcd_codec
authorStephan Gerhold <stephan@gerhold.net>
Tue, 15 Sep 2020 07:12:10 +0000 (09:12 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:49:06 +0000 (14:49 +0100)
commit87571ff9c90efaae66f071b9b61d4a6fb68fd893
treef67f1feb693cd799eb3ecfbb0d089164f53e48cf
parent4c8e4646af1b9808fe1bcf23c50d579467c14236
arm64: dts: qcom: pm8916: Remove invalid reg size from wcd_codec

BugLink: https://bugs.launchpad.net/bugs/1902115
[ Upstream commit c2f0cbb57dbac6da3d38b47b5b96de0fe4e23884 ]

Tha parent node of "wcd_codec" specifies #address-cells = <1>
and #size-cells = <0>, which means that each resource should be
described by one cell for the address and size omitted.

However, wcd_codec currently lists 0x200 as second cell (probably
the size of the resource). When parsing this would be treated like
another memory resource - which is entirely wrong.

To quote the device tree specification [1]:
  "If the parent node specifies a value of 0 for #size-cells,
   the length field in the value of reg shall be omitted."

[1]: https://www.devicetree.org/specifications/

Fixes: 5582fcb3829f ("arm64: dts: apq8016-sbc: add analog audio support with multicodec")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200915071221.72895-4-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
arch/arm64/boot/dts/qcom/pm8916.dtsi