]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: Catch invalid index in XPS mapping
authorNick Child <nnac123@linux.ibm.com>
Tue, 21 Mar 2023 15:07:24 +0000 (10:07 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 9 Aug 2023 09:37:55 +0000 (11:37 +0200)
commit877c5ed954b57d25b2f5dcd8f3efc2e9139489ff
treecc9ea045f187a874c07e8037eac865b432b7cb2e
parent76683a97ada2b3bff6f2c8ba9f7d424c862af8ea
net: Catch invalid index in XPS mapping

BugLink: https://bugs.launchpad.net/bugs/2028808
[ Upstream commit 5dd0dfd55baec0742ba8f5625a0dd064aca7db16 ]

When setting the XPS value of a TX queue, warn the user once if the
index of the queue is greater than the number of allocated TX queues.

Previously, this scenario went uncaught. In the best case, it resulted
in unnecessary allocations. In the worst case, it resulted in
out-of-bounds memory references through calls to `netdev_get_tx_queue(
dev, index)`. Therefore, it is important to inform the user but not
worth returning an error and risk downing the netdevice.

Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Link: https://lore.kernel.org/r/20230321150725.127229-1-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/core/dev.c