]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
dmaengine: sh: don't use dynamic static allocation
authorVinod Koul <vinod.koul@intel.com>
Mon, 2 Jun 2014 04:10:00 +0000 (09:40 +0530)
committerVinod Koul <vinod.koul@intel.com>
Tue, 3 Jun 2014 06:05:33 +0000 (11:35 +0530)
commit877d8425072b50965f6f04ea3a127928f66db72f
tree386a87da4c6631e4b25bab821a31ed370fe114f0
parent9d9f71a804314e7d50e2fa9e6e61bc77e2d6ae1c
dmaengine: sh: don't use dynamic static allocation

dynamic stack allocation in kernel is considered bad as kernel stack is low and
we get warns on few archs as reported by kbuild test robot

>> drivers/dma/sh/shdma-base.c:671:32: sparse: Variable length array is used.
>> drivers/dma/sh/shdma-base.c:701:1: warning: 'shdma_prep_dma_cyclic' uses
>> dynamic stack allocation [enabled by default]

Fix this by making a static array of 32 which should be sufficient for
shdma_prep_dma_cyclic which only user in kernel is audio and 32 periods for
audio seems quite sufficient atm

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/sh/shdma-base.c