]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
clk: imx: clk-imx8mp: improve error handling in imx8mp_clocks_probe()
authorYuxing Liu <lyx2022@hust.edu.cn>
Wed, 3 May 2023 07:06:07 +0000 (07:06 +0000)
committerAbel Vesa <abel.vesa@linaro.org>
Mon, 12 Jun 2023 09:20:02 +0000 (12:20 +0300)
commit878b02d5f3b56cb090dbe2c70c89273be144087f
treeba5d4566b2777b6561aa5ffa6120e317cd5c1346
parente02ba11b457647050cb16e7cad16cec3c252fade
clk: imx: clk-imx8mp: improve error handling in imx8mp_clocks_probe()

Replace of_iomap() and kzalloc() with devm_of_iomap() and devm_kzalloc()
which can automatically release the related memory when the device
or driver is removed or unloaded to avoid potential memory leak.

In this case, iounmap(anatop_base) in line 427,433 are removed
as manual release is not required.

Besides, referring to clk-imx8mq.c, check the return code of
of_clk_add_hw_provider, if it returns negtive, print error info
and unregister hws, which makes the program more robust.

Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
Signed-off-by: Yuxing Liu <lyx2022@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230503070607.2462-1-lyx2022@hust.edu.cn
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
drivers/clk/imx/clk-imx8mp.c