]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
leds: LP55XX_COMMON needs to depend on LEDS_CLASS
authorRandy Dunlap <rdunlap@infradead.org>
Mon, 17 Aug 2020 19:11:29 +0000 (12:11 -0700)
committerPavel Machek <pavel@ucw.cz>
Mon, 17 Aug 2020 20:28:36 +0000 (22:28 +0200)
commit87e236845a3415eb7a7bc6600657c494abe41390
tree5b040dc20d22d5340797ea4ad3e38531feae209f
parent46de3adb5240f33b6dbf89ca0dc4ba5c86abebb1
leds: LP55XX_COMMON needs to depend on LEDS_CLASS

With these kernel configs:
CONFIG_LEDS_CLASS=m
# CONFIG_LEDS_CLASS_MULTICOLOR is not set
CONFIG_LEDS_LP55XX_COMMON=y
CONFIG_LEDS_LP5521=m
CONFIG_LEDS_LP5562=m

leds-lp55xx-common.c has a build error because it is builtin and
calls an interface that is built as a loadable module (due to
LEDS_CLASS=m). By making LEDS_LP55XX_COMMON depend on LEDS_CLASS,
this config combination cannot happen, thus preventing the build error.

ld: drivers/leds/leds-lp55xx-common.o: in function `lp55xx_register_leds':
leds-lp55xx-common.c:(.text+0xc5f): undefined reference to `devm_led_classdev_register_ext'

Fixes: 33b3a561f417 ("leds: support new LP8501 device - another LP55xx common")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Milo Kim <milo.kim@ti.com>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/Kconfig