]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
UBI: Fix crash in try_recover_peb()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 13 Oct 2016 14:05:36 +0000 (16:05 +0200)
committerRichard Weinberger <richard@nod.at>
Wed, 19 Oct 2016 22:06:06 +0000 (00:06 +0200)
commit884a3b647809cb31cf6bd948f814e93753b38502
tree1cc3f6042d9626a668b3f4658ec405c6c540b6eb
parenta15cf34fed779d3d49d76e3a7e63bd0132b6a458
UBI: Fix crash in try_recover_peb()

    drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’:
    drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in this function

The pointer vid_hdr is indeed not initialized, leading to a crash when
it is dereferenced.

Fix this by obtaining the pointer from the VID buffer, like is done
everywhere else.

Fixes: 3291b52f9ff0acc8 ("UBI: introduce the VID buffer concept")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/eba.c