]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bcache: fixup multiple threads crash
authorMingzhe Zou <mingzhe.zou@easystack.cn>
Fri, 11 Feb 2022 06:39:15 +0000 (14:39 +0800)
committerColy Li <colyli@suse.de>
Sun, 6 Mar 2022 14:33:45 +0000 (22:33 +0800)
commit887554ab96588de2917b6c8c73e552da082e5368
tree0570e2ced54a9570d4d179770b14ce9a206646cf
parent7b1002f7cfe581930f63787a0b3de0144e61ed55
bcache: fixup multiple threads crash

When multiple threads to check btree nodes in parallel, the main
thread wait for all threads to stop or CACHE_SET_IO_DISABLE flag:

wait_event_interruptible(check_state->wait,
                         atomic_read(&check_state->started) == 0 ||
                         test_bit(CACHE_SET_IO_DISABLE, &c->flags));

However, the bch_btree_node_read and bch_btree_node_read_done
maybe call bch_cache_set_error, then the CACHE_SET_IO_DISABLE
will be set. If the flag already set, the main thread return
error. At the same time, maybe some threads still running and
read NULL pointer, the kernel will crash.

This patch change the event wait condition, the main thread must
wait for all threads to stop.

Fixes: 8e7102273f597 ("bcache: make bch_btree_check() to be multithreaded")
Signed-off-by: Mingzhe Zou <mingzhe.zou@easystack.cn>
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Coly Li <colyli@suse.de>
drivers/md/bcache/btree.c
drivers/md/bcache/writeback.c