]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: lapb: Copy the skb before sending a packet
authorXie He <xie.he.0141@gmail.com>
Mon, 1 Feb 2021 05:57:06 +0000 (21:57 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 2 Feb 2021 16:40:48 +0000 (08:40 -0800)
commit88c7a9fd9bdd3e453f04018920964c6f848a591a
treec23e141783bf91569d06000f5c3c26153b9ecbb5
parentf418bad6ccfa6f0ef6ebc783ba72bb9c5738574f
net: lapb: Copy the skb before sending a packet

When sending a packet, we will prepend it with an LAPB header.
This modifies the shared parts of a cloned skb, so we should copy the
skb rather than just clone it, before we prepend the header.

In "Documentation/networking/driver.rst" (the 2nd point), it states
that drivers shouldn't modify the shared parts of a cloned skb when
transmitting.

The "dev_queue_xmit_nit" function in "net/core/dev.c", which is called
when an skb is being sent, clones the skb and sents the clone to
AF_PACKET sockets. Because the LAPB drivers first remove a 1-byte
pseudo-header before handing over the skb to us, if we don't copy the
skb before prepending the LAPB header, the first byte of the packets
received on AF_PACKET sockets can be corrupted.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Martin Schiller <ms@dev.tdt.de>
Link: https://lore.kernel.org/r/20210201055706.415842-1-xie.he.0141@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/lapb/lapb_out.c