]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
perf annotate: Propagate the symbol__annotate() error return
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 30 Sep 2019 18:44:13 +0000 (15:44 -0300)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 17:47:06 +0000 (18:47 +0100)
commit88e089a14a725b7417d15d949d38738ba804a3ca
tree82103e6286c3313ad029a5135ee0c2c06cfbbaac
parenta22217498a600fecbe584306c00c41579fa06721
perf annotate: Propagate the symbol__annotate() error return

BugLink: https://bugs.launchpad.net/bugs/1851550
[ Upstream commit 211f493b611eef012841f795166c38ec7528738d ]

We were just returning -1 in symbol__annotate() when symbol__annotate()
failed, propagate its error as it is used later to pass to
symbol__strerror_disassemble() to present a error message to the user,
that in some cases were getting:

  "Invalid -1 error code"

Fix it to propagate the error.

Reported-by: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/n/tip-0tj89rs9g7nbcyd5skadlvuu@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
tools/perf/util/annotate.c