]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: phy: phylink: fix uninitialized variable in phylink_get_mac_state
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 26 Feb 2019 18:29:22 +0000 (19:29 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit892644cd81b05b69096b4cd4209db367210e32c2
tree273c35e1ff08444de03d934493e8986160f92e50
parentaa12139f3d35387f9ab8644f24d8a37146a7f0d5
net: phy: phylink: fix uninitialized variable in phylink_get_mac_state

BugLink: https://bugs.launchpad.net/bugs/1837813
[ Upstream commit d25ed413d5e51644e18f66e34eec049f17a7abcb ]

When debugging an issue I found implausible values in state->pause.
Reason in that state->pause isn't initialized and later only single
bits are changed. Also the struct itself isn't initialized in
phylink_resolve(). So better initialize state->pause and other
not yet initialized fields.

v2:
- use right function name in subject
v3:
- initialize additional fields

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/phy/phylink.c