]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
PNP / ACPI: proper handling of ACPI IO/Memory resource parsing failures
authorZhang Rui <rui.zhang@intel.com>
Tue, 11 Mar 2014 14:40:27 +0000 (22:40 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 11 Mar 2014 20:22:10 +0000 (21:22 +0100)
commit89935315f192abf7068d0044cefc84f162c3c81f
tree8536ce3ec6e064e3466fff7711390047872e8051
parentfa389e220254c69ffae0d403eac4146171062d08
PNP / ACPI: proper handling of ACPI IO/Memory resource parsing failures

Before commit b355cee88e3b (ACPI / resources: ignore invalid ACPI
device resources), if acpi_dev_resource_memory()/acpi_dev_resource_io()
returns false, it means the the resource is not a memeory/IO resource.

But after commit b355cee88e3b, those functions return false if the
given memory/IO resource entry is invalid (the length of the resource
is zero).

This breaks pnpacpi_allocated_resource(), because it now recognizes
the invalid memory/io resources as resources of unknown type.  Thus
users see confusing warning messages on machines with zero length
ACPI memory/IO resources.

Fix the problem by rearranging pnpacpi_allocated_resource() so that
it calls acpi_dev_resource_memory() for memory type and IO type
resources only, respectively.

Fixes: b355cee88e3b (ACPI / resources: ignore invalid ACPI device resources)
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Reported-and-tested-by: Julian Wollrath <jwollrath@web.de>
Reported-and-tested-by: Paul Bolle <pebolle@tiscali.nl>
[rjw: Changelog]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/pnp/pnpacpi/rsparser.c